Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting errors and minor modifications #579

Closed
wants to merge 2 commits into from

Conversation

gpantelis
Copy link
Contributor

With this parameters "-vcodec", "copy", "-acodec", "copy" the output video was wrong(starting time was wrong and the video freezed after a few seconds)
But when i remove those the output video was exaclty like I want to.

With this parameters "-vcodec", "copy", "-acodec", "copy" the output video was wrong(starting time was wrong and the video freezed after a few seconds)
But when i remove those the output video was exaclty like I want to
@coveralls
Copy link

coveralls commented Jun 3, 2017

Coverage Status

Coverage decreased (-0.8%) to 53.248% when pulling 1ddb7b9 on gpantelis:patch-4 into 1c5c633 on Zulko:master.

@coveralls
Copy link

coveralls commented Jun 3, 2017

Coverage Status

Coverage remained the same at 65.44% when pulling edb4ac4 on gpantelis:patch-4 into 497c852 on Zulko:master.

@gpantelis
Copy link
Contributor Author

@Earney i think this can solve the #508 issue

@tburrows13 tburrows13 added the bug-fix For PRs and issues solving bugs. label Jun 6, 2017
@ghost
Copy link

ghost commented Jun 6, 2017

@gpantelis awesome.. I'll take a look.

@scrpy
Copy link

scrpy commented Nov 16, 2017

Gentle bump :-)

@keikoro keikoro added the review-needed PRs which need to be reviewed (further) by project maintainers. label Nov 25, 2017
@gpotter2
Copy link

gpotter2 commented Dec 9, 2018

Hi,
Here is a much better answer: https://stackoverflow.com/a/33188399/5459467
It fully fixes moviepy to simply switch the --ss and -i line.

This fix is kinda wrong, you do want to copy the video and audio codecs, since this isn't the default..

@gpotter2 gpotter2 mentioned this pull request Dec 9, 2018
1 task
@adrianhust
Copy link

With this parameters "-vcodec", "copy", "-acodec", "copy" the output video was wrong(starting time was wrong and the video freezed after a few seconds)
But when i remove those the output video was exaclty like I want to.

35 cmd = [get_setting("FFMPEG_BINARY"),"-y",
36 ¦ ¦ "-i", filename,
37 ¦ ¦ "-ss", "%0.2f"%t1,
38 ¦ ¦ "-t", "%0.2f"%(t2-t1),
39 ¦ ¦ targetname]
40 ¦ ¦ #"-vcodec", "copy", "-acodec", "copy", targetname]

just remove // "-vcodec", "copy", "-acodec", "copy", // in lib/python2.7/site-packages/moviepy/video/io/ffmpeg_tools.py it works for me

@gpotter2
Copy link

gpotter2 commented Mar 4, 2019

#848 is a better fix to the issue than this PR, which has a pretty bad effect on quality + messes with the codecs 😄

it applies this solution

@keikoro keikoro closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs. review-needed PRs which need to be reviewed (further) by project maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants