Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX changed order of specifications -ss befor -i for ffmpeg_extract_subclip() #848

Merged
merged 1 commit into from
Mar 4, 2019
Merged

FIX changed order of specifications -ss befor -i for ffmpeg_extract_subclip() #848

merged 1 commit into from
Mar 4, 2019

Conversation

grszkthfr
Copy link
Contributor

@grszkthfr grszkthfr commented Sep 6, 2018

Refers to #847

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

@gpotter2
Copy link

gpotter2 commented Mar 4, 2019

Hi ! It seems I was late on this issue 😄 you were here before me and my #882

Here is some doc I could gather, showing that this fix is the correct one:

6e78421b-086a-4db5-94b9-5389977f4040

The fix (I tested it multiple times with various parameters) is directly inspired from https://stackoverflow.com/a/33188399/5459467 which quotes the above doc.

This PR fixes #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants