Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'RemovedInDjango110Warning' #3

Merged
merged 1 commit into from Jul 16, 2016
Merged

Conversation

foo-calls-bar
Copy link
Contributor

Django==1.9.6, 1.9.7 complains about calling django.template.loader.get_template with a Context object, rather than a dict:

$ ./manage.py generate_favicon logo.png
Are you sure you want to continue? [Y/n]
Launch favicon generation and uploading
/home/foo/favicon/utils.py:67: RemovedInDjango110Warning: render() must be called with a dict, 
not a Context.
  output_content = template.render(Context({'tile_color': 'FFFFFF'}))

I simply updated the offending line in utils.py. It seems to work fine now with 1.9.6, 1.9.7, and runtests.py still succeeds:

$ ./manage.py generate_favicon logo.png
Are you sure you want to continue? [Y/n] 
Launch favicon generation and uploading

@coveralls
Copy link

coveralls commented Jul 16, 2016

Coverage Status

Coverage remained the same at 94.262% when pulling 79177ae on ryankaiser:merge into 6f95761 on ZuluPro:master.

@foo-calls-bar
Copy link
Contributor Author

foo-calls-bar commented Jul 16, 2016

Sorry about that last one. I accidently pushed another local branch to remote master, so I just re-forked and opened this new request. It should be good now.

@ZuluPro
Copy link
Owner

ZuluPro commented Jul 16, 2016

I saw your other contributions, they are welcome.
Thank you again.

@ZuluPro ZuluPro closed this Jul 16, 2016
@ZuluPro ZuluPro reopened this Jul 16, 2016
@ZuluPro ZuluPro merged commit 363a0be into ZuluPro:master Jul 16, 2016
@foo-calls-bar foo-calls-bar deleted the merge branch July 16, 2016 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants