Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

fix: screen analytics #28

Closed

Conversation

mateusforgi
Copy link

@mateusforgi mateusforgi commented Dec 14, 2021

Related Issues

#1793

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.
  • I have made the documentation changes or I created an issue explaining how to document this change on Docs issues. Please link the issue here:

@mateusforgi
Copy link
Author

@hectorcustodiozup I created this new pull request with the fix on the commit sign off

@hectorcustodiozup
Copy link
Contributor

@mateusforgi it seems your commit is still not signed did you commit it using the -s flag? If so, can you git log and check if both the Author and email are the same for the signature.

@hectorcustodiozup
Copy link
Contributor

hectorcustodiozup commented Dec 14, 2021

Our team member @Tiagoperes has also added extra details on the issue you opened earlier on this subject and I am afraid that the identifier property has been deprecated for the screen component.

Would you mind taking a look and check if the suggested solution makes sense for your scenario?
ZupIT/beagle#1793.

@mateusforgi mateusforgi deleted the hotfix/screen-analytics-identifier branch December 16, 2021 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants