This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
chore: merge 1.4.0 into master #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: parse color when is RGB size Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor: change method structure in ColorUtils.kt Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor tests method names Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br>
* refactor: remove deprecated from constructor * fix: adjust name action backend * fix: adjust serialization context * adjust try serializer * adjust context data manager * adjust try to deserializer * adjust unit tests * adjust class * remove space extra * adjust test in form * adjust evaluation * adjust lint * fix: adjust context data evaluation to enum * adjust lint
* crash app in cache * private val in ContextBinding Co-authored-by: Frederico Noce <p000rbertholucci@prservicos.com.br>
* fix: BeagleFragment breaking change Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * adjust test methods name Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * remove unnused imports Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br>
…ger (#1070) * fix: remove default implementation * adjust tests * add error when api it is empty * adjust unit tests * adjust unit tests * adjust message * adjust unit test * adjust unit test * format url * adjust comment
…ger (#1073) * remove network client from dependencies * remove DefaultCache and DefaultLogger from Beagle * add defult implementations on demo * fix tests compiling issues and remove CacheDiskManager from Beagle * fix BeagleDependencies tests * handle network client nil * remove main storyboard from BeagleDemo * reorganizing BeagleDemo file structure * SendRequest now executes error when there is some infrastructure problem * fix code smell * fix code smell Co-authored-by: Daniel Tes Carrasque <daniel@zup.com.br> Co-authored-by: Lucas Araújo <lucas.araujo@zup.com.br>
uziasferreirazup
requested review from
caioortu,
danilorochazup,
dantes-git,
gabcoelho,
gabrielleonardozup,
heliojuniorzup,
hernandazevedozup,
hthemir,
jefersonlopeszup,
lucasaraujo,
lucasfonsecazup,
lucka3s and
matheusribeirozup
as code owners
uziasferreirazup
requested review from
paulomeurerzup,
renatagandrade,
tarcisiogc,
theffc,
tiagonuneszup,
tuliopereirazup and
yandiaszup
as code owners
github-actions
bot
added
android
Generated by 🚫 Danger |
|
Kudos, SonarCloud Quality Gate passed!
|
Generated by 🚫 Danger |
viniciusguardieirozup
approved these changes
Oct 26, 2020
hernandazevedozup
approved these changes
Oct 26, 2020
theffc
approved these changes
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Last week, we had to make a release to solve some potential security problems for users that don't customize beagle core mechanisms (network client, logger, cache) with their own implementation. Since it's impractical to have a default implementation that would satisfy completely different security concerns, we decided to remove our default implementation of these mechanisms, and let users implement their own with security concerns bounded to their specific context.
Since our master branch had features being developed, we were unable to generate a release from it. Therefore a new branch was created from the last release (1.3.0), which also incorporates hot fixes from both platforms.
Now with this PR, this code with security changes will be integrated into
master.