fix: adjust context evaluation to return correct types #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uziasferreirazup
requested review from
danilorochazup,
gabrielleonardozup,
hernandazevedozup,
hthemir,
jefersonlopeszup,
lucka3s,
matheusribeirozup,
paulomeurerzup,
tarcisiogc and
tiagonuneszup
as code owners
github-actions
bot
added
the
android
Codecov Report
@@ Coverage Diff @@
## release/1.3.1-android #1043 +/- ##
===========================================================
+ Coverage 78.23% 81.09% +2.85%
- Complexity 1189 1201 +12
===========================================================
Files 539 540 +1
Lines 15952 15708 -244
Branches 562 556 -6
===========================================================
+ Hits 12480 12738 +258
+ Misses 3168 2663 -505
- Partials 304 307 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
android/beagle/src/main/java/br/com/zup/beagle/android/components/form/core/FormSubmitter.kt
Outdated
Show resolved
Hide resolved
matheusribeirozup
approved these changes
Oct 18, 2020
viniciusguardieirozup
suggested changes
Oct 19, 2020
android/beagle/src/test/java/br/com/zup/beagle/android/context/ContextDataEvaluationTest.kt
Show resolved
Hide resolved
android/beagle/src/test/java/br/com/zup/beagle/android/context/ContextDataEvaluationTest.kt
Show resolved
Hide resolved
android/beagle/src/test/java/br/com/zup/beagle/android/utils/ActionExtensionsKtTest.kt
Show resolved
Hide resolved
android/beagle/src/test/java/br/com/zup/beagle/android/utils/ActionExtensionsKtTest.kt
Show resolved
Hide resolved
android/beagle/src/test/java/br/com/zup/beagle/android/utils/ActionExtensionsKtTest.kt
Show resolved
Hide resolved
viniciusguardieirozup
approved these changes
Oct 19, 2020
android/beagle/src/main/java/br/com/zup/beagle/android/context/ContextDataEvaluation.kt
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
uziasferreirazup
added a commit
that referenced
this pull request
Oct 21, 2020
* fix: parse color when is RGB size (#1033) * fix: parse color when is RGB size Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor: change method structure in ColorUtils.kt Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor tests method names Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * fix: adjust http client default to handle exception when set body (#1050) * fix: adjust override title when navigate in screen (#1052) * fix: adjust context evaluation to return correct types (#1043) * refactor: remove deprecated from constructor * fix: adjust name action backend * fix: adjust serialization context * adjust try serializer * adjust context data manager * adjust try to deserializer * adjust unit tests * adjust class * remove space extra * adjust test in form * adjust evaluation * adjust lint * fix: adjust context data evaluation to enum * adjust lint * fix: maxSize cache of ContextBinding (#1058) * crash app in cache * private val in ContextBinding Co-authored-by: Frederico Noce <p000rbertholucci@prservicos.com.br> * fix: BeagleFragment breaking change (#1057) * fix: BeagleFragment breaking change Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * adjust test methods name Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * remove unnused imports Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * adjust import Co-authored-by: Matheus Ribeiro Lima <57918064+matheusribeirozup@users.noreply.github.com> Co-authored-by: viniciusguardieirozup <58824112+viniciusguardieirozup@users.noreply.github.com> Co-authored-by: Frederico Sisconetto Noce <frederico.noce@zup.com.br> Co-authored-by: Frederico Noce <p000rbertholucci@prservicos.com.br> Co-authored-by: paulomeurerzup <66129650+paulomeurerzup@users.noreply.github.com>
uziasferreirazup
added a commit
that referenced
this pull request
Oct 26, 2020
* fix: parse color when is RGB size (#1033) * fix: parse color when is RGB size Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor: change method structure in ColorUtils.kt Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor tests method names Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * fix: adjust http client default to handle exception when set body (#1050) * fix: adjust override title when navigate in screen (#1052) * fix: adjust context evaluation to return correct types (#1043) * refactor: remove deprecated from constructor * fix: adjust name action backend * fix: adjust serialization context * adjust try serializer * adjust context data manager * adjust try to deserializer * adjust unit tests * adjust class * remove space extra * adjust test in form * adjust evaluation * adjust lint * fix: adjust context data evaluation to enum * adjust lint * fix: maxSize cache of ContextBinding (#1058) * crash app in cache * private val in ContextBinding Co-authored-by: Frederico Noce <p000rbertholucci@prservicos.com.br> * fix: BeagleFragment breaking change (#1057) * fix: BeagleFragment breaking change Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * adjust test methods name Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * remove unnused imports Signed-off-by: paulomeurerzup <paulo.meurer@zup.com.br> * fix addChildren schema (#1049) * path parser fix (#1060) * fix: scroll view content now can grow to match screen height * fix: adjust some fake vulnerability changing the names used (#1071) * fix: Remove default implementation of Cache, HttpClient and BeagleLogger (#1070) * fix: remove default implementation * adjust tests * add error when api it is empty * adjust unit tests * adjust unit tests * adjust message * adjust unit test * adjust unit test * format url * adjust comment * fix: adjust log to show toast on PreviewActivity.kt (#1072) * fix: remove default implementation of Cache, HttpClient and BeagleLogger (#1073) * remove network client from dependencies * remove DefaultCache and DefaultLogger from Beagle * add defult implementations on demo * fix tests compiling issues and remove CacheDiskManager from Beagle * fix BeagleDependencies tests * handle network client nil * remove main storyboard from BeagleDemo * reorganizing BeagleDemo file structure * SendRequest now executes error when there is some infrastructure problem * fix code smell * fix code smell Co-authored-by: Daniel Tes Carrasque <daniel@zup.com.br> Co-authored-by: Lucas Araújo <lucas.araujo@zup.com.br> * adjust preview * adjust import Co-authored-by: Matheus Ribeiro Lima <57918064+matheusribeirozup@users.noreply.github.com> Co-authored-by: viniciusguardieirozup <58824112+viniciusguardieirozup@users.noreply.github.com> Co-authored-by: Frederico Sisconetto Noce <frederico.noce@zup.com.br> Co-authored-by: Frederico Noce <p000rbertholucci@prservicos.com.br> Co-authored-by: paulomeurerzup <66129650+paulomeurerzup@users.noreply.github.com> Co-authored-by: Daniel Tes <daniel@zup.com.br> Co-authored-by: theffc <frederico.calhau@zup.com.br> Co-authored-by: Lucas Araújo <lucas.araujo@zup.com.br>
uziasferreirazup
added a commit
that referenced
this pull request
Oct 27, 2020
* fix: parse color when is RGB size (#1033) * fix: parse color when is RGB size Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor: change method structure in ColorUtils.kt Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * refactor tests method names Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br> * fix: adjust http client default to handle exception when set body (#1050) * remove shared code bettween backend and android * adjust detekt * refactor: move module kotlin-core to inside beagle to possible add bind in fields of core * fix: adjust override title when navigate in screen (#1052) * fix: adjust context evaluation to return correct types (#1043) * refactor: remove deprecated from constructor * fix: adjust name action backend * fix: adjust serialization context * adjust try serializer * adjust context data manager * adjust try to deserializer * adjust unit tests * adjust class * remove space extra * adjust test in form * adjust evaluation * adjust lint * fix: adjust context data evaluation to enum * adjust lint * adjust suppor to bind * remove module kotlin-core * fix: adjust support to bind * adjust code * remove code used to test * create unit test to mapper and flex view * adjust import * adjust function * adjust layout change * adjust unit test * adjust unit test * adjust unit test Co-authored-by: Matheus Ribeiro Lima <57918064+matheusribeirozup@users.noreply.github.com> Co-authored-by: viniciusguardieirozup <58824112+viniciusguardieirozup@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
closes issue #958
Description and Example
Adjust to set context always normalize value.
Adjust SendRequest to just normalize value and create an implicit context.
Remove method
trytodeserializeand adjust the evaluation of the expression to return correct typeChecklist
Please, check if these important points are met using
[x]: