Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

feat: add support to bind in Display #1086

Merged
merged 24 commits into from
Oct 27, 2020
Merged

Conversation

uziasferreirazup
Copy link
Contributor

Related Issues

Closes #1063

Description and Example

Add support to bind in display

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.

matheusribeirozup and others added 19 commits October 16, 2020 09:41
* fix: parse color when is RGB size

Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br>

* refactor: change method structure in ColorUtils.kt

Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br>

* refactor tests method names

Signed-off-by: Matheus Ribeiro <matheus.ribeiro@zup.com.br>
* refactor: remove deprecated from constructor

* fix: adjust name action backend

* fix: adjust serialization context

* adjust try serializer

* adjust context data manager

* adjust try to deserializer

* adjust unit tests

* adjust class

* remove space extra

* adjust test in form

* adjust evaluation

* adjust lint

* fix: adjust context data evaluation to enum

* adjust lint
@github-actions github-actions bot added the android This issue directly affects structure and logic of Android project label Oct 26, 2020
@botbeaglezup
Copy link
Contributor

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link
Contributor

@gabrielleonardozup gabrielleonardozup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1086 into master will decrease coverage by 4.37%.
The diff coverage is 83.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1086      +/-   ##
============================================
- Coverage     82.02%   77.64%   -4.38%     
+ Complexity     1189     1074     -115     
============================================
  Files           539      171     -368     
  Lines         15997     3431   -12566     
  Branches        562      519      -43     
============================================
- Hits          13121     2664   -10457     
+ Misses         2572      472    -2100     
+ Partials        304      295       -9     
Flag Coverage Δ Complexity Δ
#android 77.64% <83.50%> (+0.38%) 1074.00 <42.00> (+2.00)
#backend ? ?
#ios ? ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@uziasferreirazup uziasferreirazup merged commit 32e93a2 into master Oct 27, 2020
@uziasferreirazup uziasferreirazup deleted the feat/add-support-to-bind branch October 27, 2020 17:06
@uziasferreirazup uziasferreirazup added the documentation Improvements or additions to documentation label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
android This issue directly affects structure and logic of Android project documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to bind in display
6 participants