This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
feat: add output middleware to the golang template #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
lucasdittrichzup
added
feature
lucasdittrichzup
requested review from
kaduartur,
victorschumacherzup,
brunasilvazup and
henriquemoraeszup
| Output map[string]interface{} `json:"output"` | ||
| } | ||
|
|
||
| var outputFile = RitchieDir() + "/output.json" |
There was a problem hiding this comment.
I think you need to filepath join here as well, in case the use OS is windows
Comment on lines
+31
to
+41
| data := OutputJSON{output} | ||
| outputJSON, err := json.Marshal(data) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err := ioutil.WriteFile(outputFile, outputJSON, os.ModePerm); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
is this overwriting the out file? What happens if I add a key/value at one moment, then again at another moment in code
Comment on lines
+44
to
+53
| func ReadOutput() (OutputJSON, error) { | ||
| file, _ := ioutil.ReadFile(outputFile) | ||
|
|
||
| var data OutputJSON | ||
| if err := json.Unmarshal(file, &data); err != nil { | ||
| return data, err | ||
| } | ||
|
|
||
| return data, nil | ||
| } |
There was a problem hiding this comment.
I was wondering if we should have a method more like getValue in which we already pass the output key and just get that specific value. Maybe we could have both, what do you think?
|
there was a change in the implementation of this feature and this PR became unnecessary |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What I did
How I did it
How to verify it
What kind of change does this PR make
Description for the changelog