-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsing degenerate roads breaks #204
Comments
Ah my mistake, the road ordering layer is relative to the final output, not each debug step |
I have a theory that the intersection geometry code give up any time there is a loop road. That would explain the circle at the end. But the messed up geometry at step 6 is a different problem. I agree that it looks like the wrong end of r8 is being used. But maybe only for some of the calculations? It looks like the algorithm asks about the intersection between r7 and r8 without specifying which end of each road it cares about? |
This might be it.. I had a fuzzy thought earlier about how we trim the center line back based on a hit point from the projected left or right line. Right now we either maximize or minimize the length of the resulting polyline, in an attempt to find the one "closest to the intersection." I might try minimizing the distance to the actual hit point we found.. because it should pretty much always be about road_width / 2 away. I'll try both of these ideas out and try and figure this out finally. Loop roads have caused enough trouble! |
find is on the correct side. Fixes #204
https://a-b-street.github.io/osm2streets/#18.41/51.47558/-2.53673
When we collapse degenerate roads, the geometry somewhere blows up, and then this makes us incorrectly collapse a road
screencast.mp4
The text was updated successfully, but these errors were encountered: