Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Protein] add vector node features. #124

Merged
merged 10 commits into from
Mar 9, 2022
Merged

[WIP][Protein] add vector node features. #124

merged 10 commits into from
Mar 9, 2022

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Mar 7, 2022

Reference Issues/PRs

#120 #122

What does this implement/fix? Explain your changes

Adds node feature functions for vector features. (CA<->CB, CA<->Side chain, seq_i<->seq_{i+1})

What testing did you do to verify the changes in this PR?

None yet. Tests WIP.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #124 (7fe3793) into master (8123f42) will increase coverage by 1.07%.
The diff coverage is 38.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   40.27%   41.34%   +1.07%     
==========================================
  Files          48       53       +5     
  Lines        2811     3340     +529     
==========================================
+ Hits         1132     1381     +249     
- Misses       1679     1959     +280     
Impacted Files Coverage Δ
graphein/grn/parse_trrust.py 37.77% <ø> (ø)
graphein/ml/conversion.py 0.00% <0.00%> (ø)
graphein/ml/diffusion.py 0.00% <0.00%> (ø)
graphein/ppi/edges.py 100.00% <ø> (ø)
graphein/ppi/graph_metadata.py 0.00% <ø> (ø)
graphein/ppi/graphs.py 54.34% <ø> (ø)
graphein/ppi/parse_biogrid.py 75.00% <ø> (ø)
graphein/ppi/visualisation.py 0.00% <0.00%> (ø)
graphein/protein/analysis.py 0.00% <0.00%> (ø)
graphein/protein/features/sequence/embeddings.py 34.61% <ø> (-1.24%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9071090...7fe3793. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner Author

@a-r-j a-r-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-r-j a-r-j merged commit fb9836c into master Mar 9, 2022
@a-r-j a-r-j deleted the vector_features branch May 12, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants