Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #154

Merged
merged 7 commits into from
Apr 12, 2022
Merged

Patch 1 #154

merged 7 commits into from
Apr 12, 2022

Conversation

amorehead
Copy link
Contributor

Reference Issues/PRs

I noticed a TODO statement that I could readily address.

What does this implement/fix? Explain your changes

I added a way of checking that DSSP is executable before trying to use it.

What testing did you do to verify the changes in this PR?

I made sure the code runs locally.

@a-r-j
Copy link
Owner

a-r-j commented Apr 9, 2022

Thanks @amorehead ! Appreciate the PR :) Commented on a few nits.

Would you also mind updating the changelog and add yourself to the contributors if you wish?

@amorehead
Copy link
Contributor Author

amorehead commented Apr 9, 2022

@a-r-j,

No problem! Happy to contribute where I can. I've updated the CHANGELOG.md and CONTRIBUTORS.md files as you mentioned (8471876 and 441f94e), however, I cannot see your latest comments on my proposed changes. Any ideas why that may be?

graphein/protein/features/nodes/dssp.py Show resolved Hide resolved
graphein/protein/utils.py Outdated Show resolved Hide resolved
graphein/protein/utils.py Outdated Show resolved Hide resolved
graphein/protein/utils.py Show resolved Hide resolved
@a-r-j
Copy link
Owner

a-r-j commented Apr 9, 2022

@a-r-j,

No problem! Happy to contribute where I can. I've updated the CHANGELOG.md and CONTRIBUTORS.md files as you mentioned (8471876 and 441f94e), however, I cannot see your latest comments on my proposed changes. Any ideas why that may be?

Apologies, forgot to submit the review :)

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.8% 5.8% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #154 (4088b3f) into master (8123f42) will increase coverage by 7.63%.
The diff coverage is 56.23%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   40.27%   47.90%   +7.63%     
==========================================
  Files          48       58      +10     
  Lines        2811     3822    +1011     
==========================================
+ Hits         1132     1831     +699     
- Misses       1679     1991     +312     
Impacted Files Coverage Δ
graphein/grn/parse_trrust.py 37.77% <ø> (ø)
graphein/ml/diffusion.py 0.00% <0.00%> (ø)
graphein/ppi/edges.py 100.00% <ø> (ø)
graphein/ppi/graph_metadata.py 0.00% <ø> (ø)
graphein/ppi/graphs.py 54.34% <ø> (ø)
graphein/ppi/parse_biogrid.py 75.00% <ø> (ø)
graphein/ppi/visualisation.py 0.00% <0.00%> (ø)
graphein/protein/analysis.py 0.00% <0.00%> (ø)
graphein/protein/features/sequence/sequence.py 71.42% <0.00%> (+2.67%) ⬆️
graphein/protein/features/sequence/utils.py 28.00% <0.00%> (+3.00%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f677e...4088b3f. Read the comment docs.

@a-r-j a-r-j merged commit cfc44f9 into a-r-j:master Apr 12, 2022
@amorehead amorehead deleted the patch-1 branch April 12, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants