Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #221

Merged
merged 44 commits into from Oct 31, 2022
Merged

Logging #221

merged 44 commits into from Oct 31, 2022

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Oct 23, 2022

Reference Issues/PRs

N/A

What does this implement/fix? Explain your changes

Refactors logging to use loguru consistently. Also provides global enable/disable.

What testing did you do to verify the changes in this PR?

WIP

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Base: 40.27% // Head: 47.51% // Increases project coverage by +7.23% 🎉

Coverage data is based on head (7e583c4) compared to base (8123f42).
Patch coverage: 51.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   40.27%   47.51%   +7.23%     
==========================================
  Files          48       85      +37     
  Lines        2811     5382    +2571     
==========================================
+ Hits         1132     2557    +1425     
- Misses       1679     2825    +1146     
Impacted Files Coverage Δ
graphein/ml/diffusion.py 0.00% <0.00%> (ø)
graphein/ppi/graph_metadata.py 0.00% <0.00%> (ø)
graphein/ppi/visualisation.py 0.00% <0.00%> (ø)
graphein/protein/analysis.py 0.00% <0.00%> (ø)
graphein/protein/features/sequence/utils.py 28.00% <0.00%> (+3.00%) ⬆️
graphein/protein/features/utils.py 27.77% <0.00%> (ø)
graphein/utils/config.py 100.00% <ø> (+100.00%) ⬆️
graphein/utils/config_parser.py 100.00% <ø> (ø)
graphein/utils/utils.py 52.22% <ø> (+17.70%) ⬆️
graphein/ml/clustering.py 7.42% <7.42%> (ø)
... and 81 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@a-r-j a-r-j merged commit 97d0c97 into master Oct 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@a-r-j a-r-j deleted the logging branch November 10, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants