Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@a-r-j requesting a short review on this one.
I added docstrings to the
process_dataframe
function, and slightly modified its implementation for simplicity.One thing I'm a bit unsure of:
if granularity == something
shows up in two places. Do you think this can be simplified? "granularity" as a category of properties to worry about -- if it can be handled in one block of code rather than two, that would help with reasoning about the function and debugging/maintenance later on.