Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .requirements reference for extras in setup.py #330

Merged
merged 1 commit into from Aug 1, 2023

Conversation

AH-Merii
Copy link
Contributor

@AH-Merii AH-Merii commented Aug 1, 2023

Reference Issues/PRs

What does this implement/fix? Explain your changes

The extras was previously referring to .requirements/dev.in, I have now updated to refer to the correct requirements found in .requirements/extras.in

What testing did you do to verify the changes in this PR?

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

The extras was previously referring to `.requirements/dev.in`, I have now updated to refer to the correct requirements found in `.requirements/extras.in`
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AH-Merii AH-Merii changed the title Fix wrong .requirements reference for extras in setup.py Fix .requirements reference for extras in setup.py Aug 1, 2023
@a-r-j
Copy link
Owner

a-r-j commented Aug 1, 2023

Good spot!

@a-r-j a-r-j merged commit 281ce30 into a-r-j:master Aug 1, 2023
11 of 14 checks passed
@AH-Merii AH-Merii deleted the patch-1 branch August 1, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants