Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PyG 2.4+ #350

Merged
merged 17 commits into from Oct 25, 2023
Merged

Add support for PyG 2.4+ #350

merged 17 commits into from Oct 25, 2023

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Oct 24, 2023

Reference Issues/PRs

What does this implement/fix? Explain your changes

2.4 introduced breaking changes to Data.keys and Batch.keys, replacing the attribute with a method (Data.keys()). This PR adds looseversion to select the keys based on the syntax allowed by old and new PyG versions.

What testing did you do to verify the changes in this PR?

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

@a-r-j a-r-j added the dependencies Pull requests that update a dependency file label Oct 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@a-r-j a-r-j merged commit 028f416 into master Oct 25, 2023
28 of 32 checks passed
@a-r-j a-r-j mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant