Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraphs #96

Merged
merged 23 commits into from Feb 9, 2022
Merged

Subgraphs #96

merged 23 commits into from Feb 9, 2022

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Jan 7, 2022

Reference Issues/PRs

#19

What does this implement/fix? Explain your changes.

  • Adds subgraph selections and tutorial
  • Bumps to docs
  • Minor linting

What testing did you do to verify the changes in this PR?

  • Some tests in place for subgraphs. Remainder WIP.

@a-r-j a-r-j added the enhancement New feature or request label Jan 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #96 (33a2a7e) into master (8123f42) will decrease coverage by 0.23%.
The diff coverage is 43.11%.

❗ Current head 33a2a7e differs from pull request most recent head ada31a0. Consider uploading reports for the commit ada31a0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   40.27%   40.03%   -0.24%     
==========================================
  Files          48       49       +1     
  Lines        2811     3020     +209     
==========================================
+ Hits         1132     1209      +77     
- Misses       1679     1811     +132     
Impacted Files Coverage Δ
graphein/protein/visualisation.py 15.65% <0.00%> (-0.57%) ⬇️
graphein/protein/utils.py 23.77% <15.09%> (-27.45%) ⬇️
graphein/protein/subgraphs.py 73.07% <73.07%> (ø)
graphein/__init__.py 100.00% <100.00%> (ø)
graphein/protein/__init__.py 84.61% <100.00%> (+1.28%) ⬆️
graphein/_version.py 0.00% <0.00%> (-12.91%) ⬇️
graphein/protein/edges/distance.py 93.42% <0.00%> (+11.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd3da9...ada31a0. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@a-r-j a-r-j merged commit 9592dd0 into master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants