Notifications #36
Merged
Notifications #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary to prevent ibeacon monitoring on virtual devices
-support multi lines notification messages -provide heads up notification through max priority -prevent decoding large bitmap icons when on virtual devices to avoid out of memory errors -show floor nb for a POI reached notification MAPX390-52
floor on which the user is -Missing javascript side
Added JS part to show the floor of the current user location. Also connected Android-JS.
|
I have committed the proper changes to do so that JS can support this. I did not test this, as I do not have the beacon. Please tell me if this works from JS's side (my jQuery query might not be working, but it should). Please also have a look at Android side and see if I'm making the right calls. |
"help & feedback" menu entry When lastnode is null, use first node with id 0 (which is info center in our dummy json) JS call to display proper floor not working, under investigation
Using another solution. Rather than using jQuery to find the floor, keep an instance of the floor elements, and iterate through them and find which element contains the correct floor id.
|
i fixed it; have a loot |
|
MAPX390-60 |
|
Looks good, +1 |
a-songac
added a commit
that referenced
this pull request
Mar 5, 2016
Notifications Fixes #37 MAPX390-60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I added in MapJSBridge a function that will call the JS side to display the current floor; I need you to complete this for this PR