-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenge Page #158
Challenge Page #158
Conversation
9f54531
to
62ea89f
Compare
1cb6c70
to
9b190c2
Compare
9defeac
to
817b70b
Compare
I would add 2 things for improved usability:
Otherwise, it looks very good. We should, however, add a new ticket to add a skip link to the newest not completed level so you don't have to tab so much with your keyboard. |
@thomasdax98 It would be great if you could also do a review for this one, since it will act as the foundation for future pages. |
f3c5662
to
4a97937
Compare
Code Climate has analyzed commit 95d22d5 and detected 12 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 89.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.8% (0.0% change). View more on Code Climate. |
Description
Closes https://github.com/a11yphant/issues/issues/46
Review App: https://a11yphant-158-merge.cluster.a11yphant.com
Definition of Done
General
Site