-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Binius #344
Init Binius #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
@@ -100,11 +100,11 @@ impl<F: JoltField> CubicSumcheckParams<F> { | |||
if *l == F::one() && *r == F::one() { | |||
*eq | |||
} else if *l == F::one() { | |||
*r * eq | |||
*r * *eq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make it so that you can perform arithmetic operations on &F
values without dereferencing
https://stackoverflow.com/a/59547146
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binius' fields don't implement these by reference so it's hard for us to do it with the same automatic method. #380
Fixes #343 |
src/field/mod.rs
MockCommitmentScheme
rv32i_vm.rs – fib_e2e
to support multiple fieldslt
andltu
subtables which had used 2 * x * y as a shortcut