Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(network): Port Types to Alloy #239

Merged
merged 3 commits into from
Apr 30, 2024
Merged

chore(network): Port Types to Alloy #239

merged 3 commits into from
Apr 30, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 30, 2024

Description

Ports network module types to alloy.

Metadata

Fixes #234

@refcell refcell added K-chore Kind: general fixes not relating to a bug M-port Meta: Ports code to new implementations A-network Area: Network module labels Apr 30, 2024
@refcell refcell requested a review from ncitron April 30, 2024 14:43
@refcell refcell self-assigned this Apr 30, 2024
ncitron
ncitron approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you just run a cargo fmt?

@refcell refcell merged commit 88610fc into alloy Apr 30, 2024
5 checks passed
@refcell refcell mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron approved these changes

Assignees

@refcell refcell

Labels
A-network Area: Network module K-chore Kind: general fixes not relating to a bug M-port Meta: Ports code to new implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @ncitron