Add libusb_init_context and associated structs #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgramop
force-pushed
the
libusb_init_context
branch
from
85b25c5
to
0c9607e
Compare
a1ien
reviewed
Jul 22, 2024
libusb1-sys/src/lib.rs
Outdated
|
|
||
| #[repr(C)] | ||
| pub enum libusb_option { | ||
| /** Set the log message verbosity. |
There was a problem hiding this comment.
If you begin copying documentation, I suggest converting it to Rust doc format.
There was a problem hiding this comment.
Addressed, and squashed into previous commit, thanks!
dgramop
force-pushed
the
libusb_init_context
branch
from
0c9607e
to
60d6ae4
Compare
|
LGTM. But can you please run |
dgramop
force-pushed
the
libusb_init_context
branch
from
60d6ae4
to
8fac5aa
Compare
|
Formatted! |
|
LGTM. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
libusb_init(...)has been deprecated by libusb. On Android, when usinglibusb_init()without configuring libusb to skip scanning at context-init time, libusb is prone to crashing.Added this function to libusb1-sys