Reset Fixes / Update Titles #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2-4am
reviewed
Dec 22, 2019
|
it's copying from $100-105 (6 bytes). Either way works. I just think the code looks cleaner without the -1. |
|
That's not true. The LDA will set the Z flag based on the value it's loading, so whether or not the BNE branches no longer has anything to do with Y. |
|
My bad. It only works because there's nothing being used from $280-380. |
|
I mean... because $107 is zero.... |
arkanoid now reboots. moon patrol was using $100 as a variable. fixed my flag error.
missed one
removed extra space in HERO
a2-4am
reviewed
Dec 22, 2019
src/prelaunch/arkanoid.a
Outdated
| sta $602 | ||
| sta $603 | ||
| sta $604 | ||
| sta $605 ; NOP setting the reset |
There was a problem hiding this comment.
You should be able to do this in fewer steps by changing STAs to BITs ($2C)
|
|
||
| ldy #6 | ||
| - lda $100-1,y | ||
| sta $280-1,y ; move hook to $280 |
There was a problem hiding this comment.
If the -1 bothers you, you can change to LDY #5 and BPL, and use $100,y and $280,y. Entirely up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.