Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIG: Update GitHub Actions trigger #295

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

ucokzeko
Copy link
Member

Missing this from the previous PR 😀

Copy link
Collaborator

@zacbrannelly zacbrannelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

Comment on lines +8 to +9
branches:
- main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Probably should only run on tag push, not push to main.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to use the main push for verifying merged commits.
Otherwise, happy to remove it

@ucokzeko ucokzeko marked this pull request as ready for review August 22, 2022 04:51
@akashagarwal7
Copy link

Unrelated - I was looking for existing python setups for GH actions in our org. You should be able to cache pip too.

@ucokzeko
Copy link
Member Author

Unrelated - I was looking for existing python setups for GH actions in our org. You should be able to cache pip too.

Good find!
I'll add it in to this PR too

@zacbrannelly zacbrannelly merged commit 2cfc897 into main Feb 15, 2024
4 checks passed
@zacbrannelly zacbrannelly deleted the config/update-actions branch February 15, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants