Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 3.0 support #214

Merged
merged 1 commit into from Jan 12, 2016
Merged

Symfony 3.0 support #214

merged 1 commit into from Jan 12, 2016

Conversation

idildin
Copy link

@idildin idildin commented Dec 13, 2015

@@ -62,14 +64,13 @@ public function buildForm(FormBuilderInterface $builder, array $options)
public function buildView(FormView $view, FormInterface $form, array $options)
{
$view->vars['default_locale'] = $this->localeProvider->getDefaultLocale();
$view->vars['required_locales'] = $options['required_locales'];
}
$view->vars['required_locales'] = $this->localeProvider->getRequiredLocales();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change the logic if someone want override required locales for specific form

@tobias-93
Copy link
Contributor

ping @idildin @webda2l

webda2l added a commit that referenced this pull request Jan 12, 2016
@webda2l webda2l merged commit b01e953 into a2lix:master Jan 12, 2016
@webda2l
Copy link
Member

webda2l commented Jan 12, 2016

Ok, thanks @idildin

@tobias-93 Give a try to "a2lix/translation-form-bundle": "@dev" and I will tag a new release a bit later if all is right

@tobias-93
Copy link
Contributor

@webda2l Everything works fine without deprecation warnings, please tag :)
@idildin 👍

@webda2l
Copy link
Member

webda2l commented Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants