Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not use width and height attributes to calculate data-aspectratio if available? #642

Closed
Hlsgs opened this issue Apr 23, 2019 · 3 comments
Closed

Why not use width and height attributes to calculate data-aspectratio if available? #642

Hlsgs opened this issue Apr 23, 2019 · 3 comments

Comments

@Hlsgs
Copy link

Hlsgs commented Apr 23, 2019

Just a quick a hopefully not dumb question ^ :)

I'm having to do extra queries in Wordpress to get the image size so as to add the "data-aspectratio" attribute while cusmomizing the "sizes" attributes(I only use sizes="auto" when necessary), when WP already always provides the width and height attributes. This in in conjunction with object-fit and your parent fit plugin.
aFarkas added a commit that referenced this issue Apr 23, 2019
@aFarkas
Use width/heeight content attributes to determine physical aspect rat…
697e929 
…io of images (fixes #642)
@aFarkas
Copy link
Owner

aFarkas commented Apr 23, 2019

Thank you

@aFarkas aFarkas closed this as completed Apr 23, 2019
@thasmo
Copy link

thasmo commented May 13, 2019

This is the best feature ever. ❤️

@thasmo
Copy link

thasmo commented May 13, 2019

Oh, I just realized - is there a reason this has not been implemented in plugins/aspectratio?

@sacr3dc0w sacr3dc0w mentioned this issue May 16, 2019
Closed
@dependabot dependabot bot mentioned this issue Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thasmo @aFarkas @Hlsgs