Hide/Unhide and Fix in Shortest Path #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Fork
…h without nth deselet
aachman98
approved these changes
Dec 28, 2019
|
|
||
| def functionality(self): | ||
| bpy.ops.mesh.hide( | ||
| unselected = self.inputs["Unselected"].default_value, |
|
|
||
| def functionality(self): | ||
| bpy.ops.mesh.reveal( | ||
| select = self.inputs["Select"].default_value, |
| @@ -13,8 +13,8 @@ class ScSelectShortestPath(Node, ScSelectionNode): | |||
| in_step: BoolProperty(update=ScNode.update_value) | |||
| in_distance: BoolProperty(update=ScNode.update_value) | |||
| in_fill: BoolProperty(update=ScNode.update_value) | |||
| in_nth: IntProperty(default=1, min=1, update=ScNode.update_value) | |||
| in_skip: IntProperty(default=1, min=1, update=ScNode.update_value) | |||
| in_nth: IntProperty(default=1, min=0, update=ScNode.update_value) | |||
There was a problem hiding this comment.
According to blender docs:
"nth" attribute can take minimum value of 1, so a value of 0 will nevertheless be internally to 1.
| @@ -31,8 +31,8 @@ def error_condition(self): | |||
| return( | |||
| super().error_condition() | |||
| or (not self.inputs["Edge Tag"].default_value in ['SELECT', 'SEAM', 'SHARP', 'CREASE', 'BEVEL', 'FREESTYLE']) | |||
| or self.inputs["Nth Selection"].default_value < 1 | |||
| or self.inputs["Skip"].default_value < 1 | |||
| or self.inputs["Nth Selection"].default_value < 0 | |||
There was a problem hiding this comment.
I forgot to convert these values using int(). And the function call below also needs to be provided with int arguments for "nth, "skip" and "offset".
If you are editing this commit, then please make these changes too.
CORPSE-SYS
commented
Dec 28, 2019
aachman98
approved these changes
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.