Merge pull request #37 from hedgepigdaniel/5.0-async-deps

Add option to allow cycles that include an asynchronous dependency

README.md

@@ -22,6 +22,9 @@ module.exports = {
       exclude: /a\.js|node_modules/,
       // add errors to webpack instead of warnings
       failOnError: true,
+      // allow import cycles that include an asyncronous import,
+      // e.g. via import(/* webpackMode: "weak" */ './file.js')
+      allowAsyncCycles: false,
       // set the current working directory for displaying module paths
       cwd: process.cwd(),
     })

index.js

@@ -8,6 +8,7 @@ class CircularDependencyPlugin {
     this.options = extend({
       exclude: new RegExp('$^'),
       failOnError: false,
+      allowAsyncCycles: false,
       onDetected: false,
       cwd: process.cwd()
     }, options)
@@ -82,6 +83,8 @@ class CircularDependencyPlugin {
       if (!depModule) { continue }
       // ignore dependencies that don't have an associated resource
       if (!depModule.resource) { continue }
+      // ignore dependencies that are resolved asynchronously
+      if (this.options.allowAsyncCycles && dependency.weak) { continue }
 
       if (depModule.debugId in seenModules) {
         if (depModule.debugId === initialModule.debugId) {