Skip to content

Commit

Permalink
ticket: 6734
Browse files Browse the repository at this point in the history
version_fixed: 1.8.2
status: resolved

pull up r24102 from trunk

 ------------------------------------------------------------------------
 r24102 | ghudson | 2010-05-24 22:44:45 -0400 (Mon, 24 May 2010) | 11 lines

 ticket: 6734
 subject: FAST negotiation could erroneously succeed
 target_version: 1.8.2
 tags: pullup

 When FAST negotiation is performed against an older KDC
 (rep->enc_part2->flags & TKT_FLG_ENC_PA_REP not set),
 krb5int_fast_verify_nego did not set the value of *fast_avail, causing
 stack garbage to be used in init_creds_step_reply.  Initialize
 *fast_avail at the beginning of the function per coding practices.

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-8@24111 dc483132-0cff-0310-8789-dd5450dbe970
  • Loading branch information
tlyu committed May 28, 2010
1 parent 5639987 commit 58075ad
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/lib/krb5/krb/fast.c
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,7 @@ krb5int_fast_verify_nego(krb5_context context,
krb5_data scratch;
krb5_boolean valid;

*fast_avail = FALSE;
if (rep->enc_part2->flags& TKT_FLG_ENC_PA_REP) {
pa = krb5int_find_pa_data(context, rep->enc_part2->enc_padata,
KRB5_ENCPADATA_REQ_ENC_PA_REP);
Expand Down

0 comments on commit 58075ad

Please sign in to comment.