Skip to content

Commit

Permalink
gcc -Wall cleanups. Mainly adding prototypes and
Browse files Browse the repository at this point in the history
making sure that functions have return types declared.

	* ss_internal.h: Add ss_pager_create prototype.

	* ss.h: Add ss_list_requests prototype.

	* request_tbl.c (ss_add_request_table, ss_delete_request_table):
        Declare function types as void.

	* prompt.c (ss_set_prompt): Declare function as void.

	* listen.c (ss_quit): Int function should return a value.

	* list_rqs.c (ss_list_requests): Fix arguments to match proper
        prototype for a ss type handler.

	* execute_cmd.c (ss_execute_command): Declare as returning int


git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@10504 dc483132-0cff-0310-8789-dd5450dbe970
  • Loading branch information
epeisach committed Mar 30, 1998
1 parent ab9d83c commit f0c6bb8
Show file tree
Hide file tree
Showing 10 changed files with 35 additions and 4 deletions.
18 changes: 18 additions & 0 deletions src/util/ss/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
Mon Mar 30 11:30:00 1998 Ezra Peisach <epeisach@kangaroo.mit.edu>

* ss_internal.h: Add ss_pager_create prototype.

* ss.h: Add ss_list_requests prototype.

* request_tbl.c (ss_add_request_table, ss_delete_request_table):
Declare function types as void.

* prompt.c (ss_set_prompt): Declare function as void.

* listen.c (ss_quit): Int function should return a value.

* list_rqs.c (ss_list_requests): Fix arguments to match proper
prototype for a ss type handler.

* execute_cmd.c (ss_execute_command): Declare as returning int

Wed Feb 18 16:35:55 1998 Tom Yu <tlyu@mit.edu>

* Makefile.in: Remove trailing slash from thisconfigdir. Fix up
Expand Down
3 changes: 2 additions & 1 deletion src/util/ss/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ HDRS = $(HDRDIR)/ss.h \

BUILD_HDRS = ss_err.h
SRC_HDRS = ss.h
SRC_HDRS_DEP = $(srcdir)/ss.h

includes:: $(SRC_HDRS) $(BUILD_HDRS)
includes:: $(SRC_HDRS_DEP) $(BUILD_HDRS)
mkdir -p $(HDRDIR)
for i in $(SRC_HDRS) ; do \
if cmp $(srcdir)/$$i $(HDRDIR)/$$i >/dev/null 2>&1; then :; \
Expand Down
1 change: 1 addition & 0 deletions src/util/ss/execute_cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ static int really_execute_command (sci_idx, argc, argv)
* Notes:
*/

int
ss_execute_command(sci_idx, argv)
int sci_idx;
register char *argv[];
Expand Down
9 changes: 7 additions & 2 deletions src/util/ss/list_rqs.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,16 @@ static char const twentyfive_spaces[26] =
" ";
static char const NL[2] = "\n";

void
ss_list_requests(argc, argv, sci_idx, info_ptr)
int argc;
char **argv;
const char * const *argv;
int sci_idx;
pointer info_ptr;
#ifdef __STDC__
void *info_ptr;
#else
char *info_ptr;
#endif
{
register ss_request_entry *entry;
register char const * const *name;
Expand Down
1 change: 1 addition & 0 deletions src/util/ss/listen.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,4 +172,5 @@ int ss_quit(argc, argv, sci_idx, infop)
pointer infop;
{
ss_abort_subsystem(sci_idx, 0);
return 0;
}
1 change: 1 addition & 0 deletions src/util/ss/prompt.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <stdio.h>
#include "ss_internal.h"

void
ss_set_prompt(sci_idx, new_prompt)
int sci_idx;
char *new_prompt;
Expand Down
2 changes: 2 additions & 0 deletions src/util/ss/request_tbl.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#define ssrt ss_request_table /* for some readable code... */

void
ss_add_request_table(sci_idx, rqtbl_ptr, position, code_ptr)
int sci_idx;
ssrt *rqtbl_ptr;
Expand Down Expand Up @@ -41,6 +42,7 @@ ss_add_request_table(sci_idx, rqtbl_ptr, position, code_ptr)
*code_ptr = 0;
}

void
ss_delete_request_table(sci_idx, rqtbl_ptr, code_ptr)
int sci_idx;
ssrt *rqtbl_ptr;
Expand Down
2 changes: 1 addition & 1 deletion src/util/ss/requests.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <stdio.h>
#include "ss_internal.h"

#define DECLARE(name) name(argc,argv,sci_idx)int argc,sci_idx;char **argv;
#define DECLARE(name) void name(argc,argv,sci_idx)int argc,sci_idx;char **argv;

/*
* ss_self_identify -- assigned by default to the "." request
Expand Down
1 change: 1 addition & 0 deletions src/util/ss/ss.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ typedef struct _ss_rp_options { /* DEFAULT VALUES */
#define SS_OPT_DONT_SUMMARIZE 0x0002

void ss_help __SS_PROTO;
void ss_list_requests __SS_PROTO;
char *ss_current_request();
char *ss_name();
#ifdef __STDC__
Expand Down
1 change: 1 addition & 0 deletions src/util/ss/ss_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ int ss_execute_line();
char **ss_parse();
ss_abbrev_info *ss_abbrev_initialize PROTOTYPE((char *, int *));
void ss_page_stdin();
int ss_pager_create();

extern ss_data **_ss_table;
extern char *ss_et_msgs[];
Expand Down

0 comments on commit f0c6bb8

Please sign in to comment.