Fixed: ssl conditions in http.py

[rohitpawar2811]

Previously, when SSL was enabled, self.proto was not set, causing issues with functions like get_table_names, and get_columns.

• Fixed the Use_ssl condition, which was previously not supported when using kwargs.
• By default, session.verify is set to true; now, it is set to false. If verify_ssl is true, then enable it.

@aadel

[aadel]

Two points here:

1. I would suggest keeping session.verify to the default True and the parameter can alter that to 'False`, i.e.:

if "verify_ssl" in url.query and url.query["verify_ssl"] in [False, "False", "false"]:
  session.verify = False
 ...

2. According to the Requests documentation, there are two different session attributes: verify which is a boolean and cert which represents the path to the SSL client certificate. By contrast, only request method accepts verify parameter as either a boolean or string path to CA bundle. How does that apply to the logic below?

[rohitpawar2811]

According to the [Requests documentation](https://requests.readthedocs.io/en/latest/api), there are two different session attributes: [verify](https://requests.readthedocs.io/en/latest/api/?highlight=verify#requests.Session.verify) which is a boolean and [cert](https://requests.readthedocs.io/en/latest/api/?highlight=verify#requests.Session.cert) which represents the path to the SSL client certificate. By contrast, only request method accepts verify parameter as either a boolean or string path to CA bundle. How does that apply to the logic below?

Actually here I have refered below condition in _solrdbapi.py : I think then should we have to change this also?

if verify_ssl is False:
    session.verify = False
else:
    if ca_certs is not None:
        session.verify = ca_certs
    else:
        session.verify = True

[rohitpawar2811]

I would suggest keeping session.verify to the default True and the parameter can alter that to 'False`, i.e.:
if "verify_ssl" in url.query and url.query["verify_ssl"] in [False, "False", "false"]:
  session.verify = False 
 

Are you intending to enforce certificate verification by default unless the client explicitly sets verify_ssl to False?

[rohitpawar2811]

@aadell,
According to your thoughts, I have made some changes. Please take a look at them and let me know if any modifications are needed.

Thank you.

[aadel]

Hi @rohitpawar2811 LGTM. thank you for your contribution!

[rohitpawar2811]

Thanks, @aadel, for your support. I'm curious about when these changes will be available in the next release. Could you please provide the expected release date? Also, could you share your LinkedIn ID? I'd like to add you to my connections. It's been great to connect with you.

[aadel]

1. I estimate the next release will be available by January 5, 2024, which will include SSL updates along with all resolved issues since 0.2.2.1.
2. Sure! You're welcome to connect on LinkedIn.

Thanks!

[rohitpawar2811]

Okay thanks for info.

https://www.linkedin.com/in/rohitpawar2811/ : connect me