Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable (exclude) keys which don't have the shaky issue #113

Closed
mmathys opened this issue Aug 8, 2019 · 6 comments
Closed

Disable (exclude) keys which don't have the shaky issue #113

mmathys opened this issue Aug 8, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@mmathys
Copy link
Contributor

mmathys commented Aug 8, 2019

In my case there are certain keys which don't have shaky issue. For example the keys {Left, Right, Up, Down, Delete}. Therefore I set the delay of these keys to 0.

When I set the configure the delay for all other keys with the "set ALL to (ms)" option, the value of the keys {Left, Right, Up, Down, Delete} are overidden each time. I then have to set the value of these keys again to 0. This happens everytime I configure the delay, which is annoying.

As a user I would like to disable these keys permanently. For example with a context menu, right click → delete.

@Zandor300
Copy link
Contributor

I think a checkbox for each key for "Include in set-all" would be easier. The state of this checkbox should be remembered to actually solve the issue of having to keep track of the setting for these keys.

@aahung aahung added the enhancement New feature or request label Aug 9, 2019
@mmathys
Copy link
Contributor Author

mmathys commented Aug 9, 2019

Checkboxes are more visible you are right. However I would not name it "include in set-all", this is confusing in my opinion. An "is enabled" checkbox for each key would be more intuitive

@aahung
Copy link
Owner

aahung commented Aug 9, 2019

Having a checkbox to individual row makes sense. Actually, since the checkbox is kind of narrow, how about just put a two-character "On" as the column header?

aahung added a commit that referenced this issue Aug 19, 2019
@aahung
Copy link
Owner

aahung commented Aug 19, 2019

Seems no need to place "On" at all, since it is quite self-explanatory.

image

@aahung aahung closed this as completed Aug 19, 2019
@aahung
Copy link
Owner

aahung commented Aug 20, 2019

@mmathys @Zandor300 v0.6.0 is out, plz test this feature thanks!

@arekm
Copy link

arekm commented Sep 26, 2019

One checkbox to select / unselect all these checkboxes would be nice too (especially for initial unselecting if you only want to "activate" delay for few characters). There is small room before "Key" text where that checkbox could go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants