Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing super fast could result in nearly 60% (observed peak) CPU usage #41

Closed
aahung opened this issue Mar 14, 2019 · 0 comments
Closed

Typing super fast could result in nearly 60% (observed peak) CPU usage #41

aahung opened this issue Mar 14, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@aahung
Copy link
Owner

aahung commented Mar 14, 2019

Describe the bug
Reported by reddit user u/ndawg who sees over 50% CPU usage with top. I do reproduce the issue when typing super fast. Unshaky should not make 50% core usage.
@aahung aahung added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 14, 2019
aahung added a commit that referenced this issue Mar 14, 2019
@aahung
Fix an issue when Unshaky has bad performance in some situation, #41:
5db9ee1 
(detail:)
The debug window will have a hit on CPU, but even when the user close it, the hit persists.
In this commit, I force the related reference to nil after the debug window closed.
So the CPU usage is maintained at ~1% right now even when typing super fast.
@aahung aahung closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aahung