Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add burn-in param to AbsoluteStandardError #305

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Add burn-in param to AbsoluteStandardError #305

merged 4 commits into from
Mar 9, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Mar 8, 2023 •
edited
Loading

Description

This PR fixes a problem with AbsoluteStandardError whereby empty results are marked as having converged because an empty result has zero variance.

Changes

  • Add a burn-in parameter to allow for the variances to have been updated to a realistic value.

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@mdbenito mdbenito added the bug Something isn't working label Mar 8, 2023
@mdbenito mdbenito self-assigned this Mar 8, 2023
@mdbenito mdbenito marked this pull request as ready for review March 8, 2023 19:59
@mdbenito
Copy link
Collaborator Author

mdbenito commented Mar 8, 2023

@AnesBenmerzoug Tagging you so that you also see the ugliness here (Fabio already has). I'm not very proud of this tbh.

AnesBenmerzoug
AnesBenmerzoug approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@AnesBenmerzoug AnesBenmerzoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just left one comment about the documentation.

@mdbenito mdbenito merged commit 39cd265 into develop Mar 9, 2023
@mdbenito mdbenito deleted the fix/se-again branch March 9, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnesBenmerzoug AnesBenmerzoug AnesBenmerzoug approved these changes

Assignees

@mdbenito mdbenito

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdbenito @AnesBenmerzoug