Skip to content

Commit

Permalink
[ package:vm_service ] Added support for service protocol version 3.27.
Browse files Browse the repository at this point in the history
Change-Id: I1cb3ca42821f817eaa9aed98d1aabb93e53fb0ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115079
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
  • Loading branch information
bkonyi authored and commit-bot@chromium.org committed Sep 7, 2019
1 parent 13a69b5 commit 9391e15
Show file tree
Hide file tree
Showing 8 changed files with 402 additions and 3 deletions.
5 changes: 5 additions & 0 deletions pkg/vm_service/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 1.2.0
- Support service protocol version 3.27:
- Added `getCpuSamples` and `clearCpuSamples` methods
- Added `CpuSamples`, `CpuSample`, and `ProfileFunction` classes.

## 1.1.2
- Fixed issue where `closureFunction` and `closureContext` were only expected in
`Instance` objects rather than `InstanceRef`.
Expand Down
59 changes: 59 additions & 0 deletions pkg/vm_service/example/vm_service_assert.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ double assertDouble(double obj) {
return obj;
}

dynamic assertDynamic(dynamic obj) {
assertNotNull(obj);
return obj;
}

List<int> assertListOfInt(List<int> list) {
for (int elem in list) {
assertInt(elem);
Expand Down Expand Up @@ -429,6 +434,36 @@ List<vms.ContextElement> assertListOfContextElement(
return list;
}

vms.CpuSamples assertCpuSamples(vms.CpuSamples obj) {
assertNotNull(obj);
assertString(obj.type);
assertInt(obj.samplePeriod);
assertInt(obj.maxStackDepth);
assertInt(obj.sampleCount);
assertInt(obj.timeSpan);
assertInt(obj.timeOriginMicros);
assertInt(obj.timeExtentMicros);
assertInt(obj.pid);
assertListOfProfileFunction(obj.functions);
assertListOfCpuSample(obj.samples);
return obj;
}

vms.CpuSample assertCpuSample(vms.CpuSample obj) {
assertNotNull(obj);
assertInt(obj.tid);
assertInt(obj.timestamp);
assertListOfInt(obj.stack);
return obj;
}

List<vms.CpuSample> assertListOfCpuSample(List<vms.CpuSample> list) {
for (vms.CpuSample elem in list) {
assertCpuSample(elem);
}
return list;
}

vms.ErrorRef assertErrorRef(vms.ErrorRef obj) {
assertNotNull(obj);
assertString(obj.type);
Expand Down Expand Up @@ -773,6 +808,12 @@ List<vms.Message> assertListOfMessage(List<vms.Message> list) {
return list;
}

vms.NativeFunction assertNativeFunction(vms.NativeFunction obj) {
assertNotNull(obj);
assertString(obj.name);
return obj;
}

vms.NullValRef assertNullValRef(vms.NullValRef obj) {
assertNotNull(obj);
assertString(obj.type);
Expand Down Expand Up @@ -821,6 +862,24 @@ vms.Obj assertObj(vms.Obj obj) {
return obj;
}

vms.ProfileFunction assertProfileFunction(vms.ProfileFunction obj) {
assertNotNull(obj);
assertString(obj.kind);
assertInt(obj.inclusiveTicks);
assertInt(obj.exclusiveTicks);
assertString(obj.resolvedUrl);
assertDynamic(obj.function);
return obj;
}

List<vms.ProfileFunction> assertListOfProfileFunction(
List<vms.ProfileFunction> list) {
for (vms.ProfileFunction elem in list) {
assertProfileFunction(elem);
}
return list;
}

vms.ReloadReport assertReloadReport(vms.ReloadReport obj) {
assertNotNull(obj);
assertString(obj.type);
Expand Down
5 changes: 5 additions & 0 deletions pkg/vm_service/java/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
src/org/dartlang/vm/service/VmService.java
src/org/dartlang/vm/service/consumer/AllocationProfileConsumer.java
src/org/dartlang/vm/service/consumer/BreakpointConsumer.java
src/org/dartlang/vm/service/consumer/CpuSamplesConsumer.java
src/org/dartlang/vm/service/consumer/EvaluateConsumer.java
src/org/dartlang/vm/service/consumer/EvaluateInFrameConsumer.java
src/org/dartlang/vm/service/consumer/FlagListConsumer.java
Expand Down Expand Up @@ -37,6 +38,8 @@ src/org/dartlang/vm/service/element/CodeRef.java
src/org/dartlang/vm/service/element/Context.java
src/org/dartlang/vm/service/element/ContextElement.java
src/org/dartlang/vm/service/element/ContextRef.java
src/org/dartlang/vm/service/element/CpuSample.java
src/org/dartlang/vm/service/element/CpuSamples.java
src/org/dartlang/vm/service/element/ErrorKind.java
src/org/dartlang/vm/service/element/ErrorObj.java
src/org/dartlang/vm/service/element/ErrorRef.java
Expand Down Expand Up @@ -67,10 +70,12 @@ src/org/dartlang/vm/service/element/LogRecord.java
src/org/dartlang/vm/service/element/MapAssociation.java
src/org/dartlang/vm/service/element/MemoryUsage.java
src/org/dartlang/vm/service/element/Message.java
src/org/dartlang/vm/service/element/NativeFunction.java
src/org/dartlang/vm/service/element/Null.java
src/org/dartlang/vm/service/element/NullRef.java
src/org/dartlang/vm/service/element/Obj.java
src/org/dartlang/vm/service/element/ObjRef.java
src/org/dartlang/vm/service/element/ProfileFunction.java
src/org/dartlang/vm/service/element/ReloadReport.java
src/org/dartlang/vm/service/element/Response.java
src/org/dartlang/vm/service/element/RetainingObject.java
Expand Down
2 changes: 1 addition & 1 deletion pkg/vm_service/java/version.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version=3.26
version=3.27
Loading

0 comments on commit 9391e15

Please sign in to comment.