Fix for indexing FieldFormalParameterMember with unresolved field.

R=brianwilkerson@google.com Bug: dart-lang/sdk#38071 Change-Id: Ifa2f9218357f0f7bb3236f66aee34c8940c8b206 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116865 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
aam · Sep 11, 2019 · c6b0ae1 · c6b0ae1
1 parent d18bfb4
commit c6b0ae1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/pkg/analyzer/lib/src/dart/element/member.dart b/pkg/analyzer/lib/src/dart/element/member.dart
@@ -251,6 +251,10 @@ class FieldFormalParameterMember extends ParameterMember
   @override
   FieldElement get field {
     var field = (baseElement as FieldFormalParameterElement).field;
+    if (field == null) {
+      return null;
+    }
+
     return FieldMember(field, _substitution);
   }
 

diff --git a/pkg/analyzer/test/src/dart/analysis/index_test.dart b/pkg/analyzer/test/src/dart/analysis/index_test.dart
@@ -67,6 +67,19 @@ class IndexTest extends BaseAnalysisDriverTest {
     return imports[index].importedLibrary.definingCompilationUnit;
   }
 
+  test_fieldFormalParameter_noSuchField() async {
+    await _indexTestUnit('''
+class B<T> {
+  B({this.x}) {}
+
+  foo() {
+    B<int>(x: 1);
+  }
+}
+''');
+    // No exceptions.
+  }
+
   test_hasAncestor_ClassDeclaration() async {
     await _indexTestUnit('''
 class A {}