clear contents on TemplateElement#setInnerHtml before appending

Fixes flutter#18249 Change-Id: I29b12163ad5809010c4ee4ff4ce892399d26e3ea Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112485 Reviewed-by: Terry Lucas <terry@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
aam · Sep 6, 2019 · d964c50 · d964c50
1 parent c8f3f13
commit d964c50
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -28281,11 +28281,12 @@ class TemplateElement extends HtmlElement {
    *
    * See also:
    *
-   * * <https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#innerhtml-on-templates>
+   * * <https://w3c.github.io/DOM-Parsing/#the-innerhtml-mixin>
    */
   void setInnerHtml(String html,
       {NodeValidator validator, NodeTreeSanitizer treeSanitizer}) {
     text = null;
+    content.nodes.clear();
     var fragment = createFragment(html,
         validator: validator, treeSanitizer: treeSanitizer);
 

diff --git a/tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate b/tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate
@@ -14,11 +14,12 @@ $!MEMBERS
    *
    * See also:
    *
-   * * <https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#innerhtml-on-templates>
+   * * <https://w3c.github.io/DOM-Parsing/#the-innerhtml-mixin>
    */
   void setInnerHtml(String html,
     {NodeValidator validator, NodeTreeSanitizer treeSanitizer}) {
     text = null;
+    content.nodes.clear();
     var fragment = createFragment(
         html, validator: validator, treeSanitizer: treeSanitizer);