Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needed OMP changes #220

Closed
2 of 8 tasks
aantron opened this issue Aug 17, 2019 · 1 comment
Closed
2 of 8 tasks

Needed OMP changes #220

aantron opened this issue Aug 17, 2019 · 1 comment
Labels
upstream
Milestone
1.5.0

Comments

@aantron
Copy link
Owner

aantron commented Aug 17, 2019 •
edited
Loading

esy.json is mainly for installation inside NPM, to tie the OCaml version to the OCaml BuckleScript version (4.06), so that the ASTs are compatible. For standalone esy usage, we should undo this.

There are three main ways:

  1. Detect that we are running inside NPM, as opposed to being installed directly for another esy package, and run a configure script to determine the BuckleScript version and the corresponding OCaml version. I don't think this can work, because BuckleScript is a peer dependency, and NPM installs it after Bisect_ppx. It is fragile anyway.
  2. Generalize OMP so that the built PPX can read any version of AST. Ability to read any version of AST ocaml-ppx/ocaml-migrate-parsetree#78
  3. Distribute prebuilt binaries, and select the right one dynamically.
@aantron aantron added this to the 1.5.0 milestone Aug 17, 2019
aantron added a commit that referenced this issue Aug 17, 2019
@aantron
Fill out esy.json more
5538fa8 
We still can't get rid of the 4.06 compiler version constraint, because
it needs to match the BuckleScript OCaml version. See #220.
@aantron aantron changed the title Finish the esy packaging Relax BuckleScript OCaml 4.06 requirement Aug 17, 2019
This was referenced Aug 17, 2019
Closed
Closed
aantron added a commit that referenced this issue Aug 23, 2019
@aantron
Relax BuckleScript OCaml 4.06 requirement
6756718 
The major part of #220.

Most of the work as part of this change is in...

- ocaml-ppx/ocaml-migrate-parsetree#80
- ocaml-ppx/ocaml-migrate-parsetree#81
aantron added a commit that referenced this issue Aug 23, 2019
@aantron
esy.json: actually allow any OCaml compiler
3eaebae 
Part of #220.
@aantron aantron mentioned this issue Sep 4, 2019
Closed
7 tasks
@aantron aantron changed the title Relax BuckleScript OCaml 4.06 requirement Needed OMP changes Sep 4, 2019
@aantron
Copy link
Owner Author

aantron commented Feb 14, 2020

Addressed by ocaml-migrate-parsetree 1.6.0 and 395dbbf.

@aantron aantron closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@aantron