Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop_cookie helper #148

Closed
wants to merge 1 commit into from
Closed

Add drop_cookie helper #148

wants to merge 1 commit into from

Conversation

Patil2099
Copy link

Fixes #144

@thangngoc89
Copy link
Contributor

I’m not sure if this PR is read my for review or not but this is definitely not adding drop_cookie but rather modifing set_cookie ‘s signature

@aantron
Copy link
Owner

aantron commented Jul 31, 2021

I’m not sure if this PR is read my for review or not but this is definitely not adding drop_cookie but rather modifing set_cookie ‘s signature

Indeed, thanks @thangngoc89.

@Patil2099 Rather than modifying set_cookie, we need to add a new function drop_cookie that calls set_cookie internally in its implementation.

@aantron
Copy link
Owner

aantron commented Nov 8, 2021

Closing in favor of #169.

@aantron aantron closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add drop_cookie helper
3 participants