feat: Add drop_cookie helper #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
reviewed
Nov 8, 2021
|
|
||
| let set_cookie = match path with | ||
| | Some p -> set_cookie ~path:p | ||
| | None -> set_cookie ~path:(Some (prefix request)) in |
There was a problem hiding this comment.
Most of the arguments can be simply forwarded to set_cookie, e.g.
set_cookie (* ... *) ?path (* ... *)The ?secure syntax forwards an optional argument to an optional argument, so you don't have to pattern match on them and then build up a set_cookie closure gradually, as here.
I'll take care of tweaking this after merge.
There was a problem hiding this comment.
Wow thanks, I was looking for a feature like this but I could not find it anywhere.
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
I tried also building the docs but that seemed to fail for me, but I did add
Dream.drop_cookieto the cookie example.