Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Repromise.then_ to Repromise.andThen #27

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Rename Repromise.then_ to Repromise.andThen #27

merged 3 commits into from
Jul 25, 2018

Conversation

jihchi
Copy link
Contributor

@jihchi jihchi commented Jul 25, 2018

Fixes #26

@aantron aantron merged commit e082cc9 into aantron:master Jul 25, 2018
@aantron
Copy link
Owner

aantron commented Jul 25, 2018

Thanks! It seems andThen vs. flatMap is still controversial, actually. But, since andThen is a really unique identifier, we can merge this now, and do a blind search-replace to flatMap later, if that's what people turn out to really want. So, this PR is quite useful no matter the final exact naming :)

@aantron aantron mentioned this pull request Jul 25, 2018
Closed
@jihchi jihchi deleted the rename_then_to_andthen branch July 25, 2018 23:21
@aantron
Copy link
Owner

aantron commented Jul 27, 2018

Ok, it's released (as andThen) in @aantron/repromise 0.6.0. Thanks again!

@kennetpostigo
Copy link
Collaborator

I think andThen will appear friendlier to people that aren't deeply engrained in functional things or ocaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jihchi @aantron @kennetpostigo