Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Repromise.then_ to Repromise.andThen #26

Closed
aantron opened this issue Jul 25, 2018 · 0 comments
Closed

Rename Repromise.then_ to Repromise.andThen #26

aantron opened this issue Jul 25, 2018 · 0 comments

Comments

@aantron
Copy link
Owner

aantron commented Jul 25, 2018

See discussion starting from #22 (comment).

This is pretty much a search-and-replace task through src/, test/, and doc/. The only thing to watch out for is that some instances of the text "then_" are actually referring toJs.Promise.then_, and those shouldn't be replaced. They are always prefixed with Js.Promise, though, so should be easy to see.

This is a nice easy issue for taking a glance at the whole codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant