Skip to content

Commit

Permalink
Repository and Deployment refactor and cleanup (bentoml#771)
Browse files Browse the repository at this point in the history
* make sagemaker docker image have same file structure

* use consistent file names

* move operator code out of __init__ to avoid loading unused code in model server startup

* refactor deployment validator

* reorganize bento repository code

* deployment valiator test&linting error fix

* more repository code cleanup

* renaming and adding inline comments

* move out lambda operator code to separate file
  • Loading branch information
parano committed Jun 9, 2020
1 parent 2fef7df commit 208f298
Show file tree
Hide file tree
Showing 20 changed files with 1,824 additions and 1,713 deletions.
6 changes: 3 additions & 3 deletions bentoml/yatai/client/deployment_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
)
from bentoml.exceptions import BentoMLException, YataiDeploymentException
from bentoml.yatai.proto import status_pb2
from bentoml.yatai.validator import validate_deployment_pb_schema
from bentoml.yatai.validator import validate_deployment_pb
from bentoml.yatai.deployment_utils import (
deployment_yaml_string_to_pb,
deployment_dict_to_pb,
Expand Down Expand Up @@ -120,7 +120,7 @@ def create(self, deployment_info, wait):
)
)

validation_errors = validate_deployment_pb_schema(deployment_pb)
validation_errors = validate_deployment_pb(deployment_pb)
if validation_errors:
raise YataiDeploymentException(
f'Failed to validate deployment {deployment_pb.name}: '
Expand Down Expand Up @@ -168,7 +168,7 @@ def apply(self, deployment_info, wait):
)
)

validation_errors = validate_deployment_pb_schema(deployment_pb)
validation_errors = validate_deployment_pb(deployment_pb)
if validation_errors:
raise YataiDeploymentException(
f'Failed to validate deployment {deployment_pb.name}: '
Expand Down
Loading

0 comments on commit 208f298

Please sign in to comment.