Repository and Deployment refactor and cleanup #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del server startup
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
==========================================
+ Coverage 55.04% 55.33% +0.28%
==========================================
Files 105 108 +3
Lines 8182 8158 -24
==========================================
+ Hits 4504 4514 +10
+ Misses 3678 3644 -34
Continue to review full report at Codecov.
|
parano
commented
Jun 9, 2020
| @@ -37,7 +37,7 @@ def _serve(): | |||
| subprocess.check_call(['ln', '-sf', '/dev/stdout', '/var/log/nginx/access.log']) | |||
| subprocess.check_call(['ln', '-sf', '/dev/stderr', '/var/log/nginx/error.log']) | |||
|
|
|||
| nginx = subprocess.Popen(['nginx', '-c', '/opt/program/nginx.conf']) | |||
| nginx = subprocess.Popen(['nginx', '-c', '/bento/nginx.conf']) | |||
There was a problem hiding this comment.
ping @yubozhao for visibility
flosincapite
pushed a commit
to MLH-Fellowship/BentoML
that referenced
this pull request
Jun 9, 2020
* make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file
parano
pushed a commit
that referenced
this pull request
Jun 10, 2020
* Repository and Deployment refactor and cleanup (#771) * make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file * Improve robustness of shell scripts * Fix header * Fix issues in generate.sh * Fix -type in call to find Co-authored-by: cory <cory.massaro@gmail.com>
parano
added a commit
that referenced
this pull request
Jun 16, 2020
* Repository and Deployment refactor and cleanup (#771) * make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file * fix some typos + adding logging to lambda callback * fix some linting problems * fix mock not returning proper form * add trailing comma * add better logging + docs * whitespace fixes * move logging and consolidate debug line * update docs + fixed logging * fix linting issues * remove redundant logging and switch to bento logger * update docs Co-authored-by: Chaoyu <paranoyang@gmail.com> Co-authored-by: cory <cory.massaro@gmail.com>
parano
added a commit
that referenced
this pull request
Jun 22, 2020
* Repository and Deployment refactor and cleanup (#771) * make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file * fixed dockerfile to use multi-stage builds * add some docs for alternative docker images * add bash script support for building multiple python versions * add more docs * update name of docker files to reflect naming conventions and fixed docs Co-authored-by: Chaoyu <paranoyang@gmail.com> Co-authored-by: cory <cory.massaro@gmail.com>
xiwang129
pushed a commit
to MLH-Fellowship/BentoML
that referenced
this pull request
Jul 24, 2020
* make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file
xiwang129
pushed a commit
to MLH-Fellowship/BentoML
that referenced
this pull request
Jul 28, 2020
* make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
* make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
* Repository and Deployment refactor and cleanup (bentoml#771) * make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file * Improve robustness of shell scripts * Fix header * Fix issues in generate.sh * Fix -type in call to find Co-authored-by: cory <cory.massaro@gmail.com>
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
* Repository and Deployment refactor and cleanup (bentoml#771) * make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file * fix some typos + adding logging to lambda callback * fix some linting problems * fix mock not returning proper form * add trailing comma * add better logging + docs * whitespace fixes * move logging and consolidate debug line * update docs + fixed logging * fix linting issues * remove redundant logging and switch to bento logger * update docs Co-authored-by: Chaoyu <paranoyang@gmail.com> Co-authored-by: cory <cory.massaro@gmail.com>
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
* Repository and Deployment refactor and cleanup (bentoml#771) * make sagemaker docker image have same file structure * use consistent file names * move operator code out of __init__ to avoid loading unused code in model server startup * refactor deployment validator * reorganize bento repository code * deployment valiator test&linting error fix * more repository code cleanup * renaming and adding inline comments * move out lambda operator code to separate file * fixed dockerfile to use multi-stage builds * add some docs for alternative docker images * add bash script support for building multiple python versions * add more docs * update name of docker files to reflect naming conventions and fixed docs Co-authored-by: Chaoyu <paranoyang@gmail.com> Co-authored-by: cory <cory.massaro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the effort to improve code quality and make it easier for new contributors to get on board. This PR:
Motivation and Context
How Has This Been Tested?
Types of changes
Components (if applicable)
Checklist:
./dev/format.shand./dev/lint.shscript have passed(instructions).