Octopi cannot be build (probably on Qt5.11)

[pavbaranov]

I'm Qt5.11beta4 user, so maybe it's something with this. Octopi cannot be build. Relevant part of "build" is:
src/transactiondialog.cpp: In member function 'void TransactionDialog::setDetailedText(QString)': src/transactiondialog.cpp:78:63: error: invalid use of incomplete type 'class QRegularExpression' if (detailedtext.contains(QRegularExpression("pacman-[0-9]+"))) ^ In file included from /usr/include/qt/QtCore/qhashfunctions.h:44:0, from /usr/include/qt/QtCore/qlist.h:47, from /usr/include/qt/QtCore/qvariant.h:45, from /usr/include/qt/QtCore/QVariant:1, from build/ui_transactiondialog.h:12, from src/transactiondialog.h:23, from src/transactiondialog.cpp:20: /usr/include/qt/QtCore/qstring.h:83:7: note: forward declaration of 'class QRegularExpression' class QRegularExpression; ^~~~~~~~~~~~~~~~~~ make: *** [Makefile:1827: build/transactiondialog.o] Error 1 make: *** Waiting for unfinished jobs.... ==> ERROR: A failure occurred in build().
Yes, I know, that there isn't Qt5.11 stable version so now, but maybe this issue is useful for upcoming version of octopi.

[HeinzDo]

Yes, the same here with Qt5.11. release.

[demmm]

This issue is getting slightly more urgent, since pacman 5.1.0 is now out, which shipped with libalpm.so.11, up from libalpm.so.10, so Octopi is broken on systems that update to new pacman, but can't be rebuild due to incompatibility with Qt 5.11.
KaOS will keep pacman at 5.0.2 until Octopi is compatible with Qt 5.11.

[demmm]

Fix is very simple, just needed to add one new include:

--- a/src/transactiondialog.cpp	2018-05-07 00:55:25.000000000 +0200
+++ b/src/transactiondialog.cpp	2018-05-28 19:18:28.492578121 +0200
@@ -26,6 +26,7 @@
 #include <QPushButton>
 #include <QDialog>
 #include <QCloseEvent>
+#include <QRegularExpression>
 
 /*
  * This is the dialog used to show the transaction summary

Patch used:
https://github.com/KaOSx/apps/blob/master/octopi/transactiondialog.diff

[aarnt]

Thank you all !