Baduris #143
Closed
Baduris #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2019 11:58
This changeset is intended to resolve aarongustafson#129. Here we implement a much more flexible policy mechanism for handling URIs for which the plugin previous experienced errors sending a webmention. Errors are classified into three different categories (unsupported, error, failure), and separate policies can be defined for each, allowing the user a lot of control over how the plugin treats these conditions.
Where the plugin currently has a feature to control retries for whole hosts, what it lacks is a mechanism to have the plugin give up on individual webmentions. This is really another aspect of issue aarongustafson#129. This commit introduces a new max_attempts setting which, if set, will cause the plugin to give up and mark a webmention as sent after a configured number of tries.
|
I was hit by the exact same issue that prompted this PR (I had a link to https://brid.gy which caused it to stop sending to the bridgy publish URL) My only quibble would be with the regex in the config. Regex are kind of awkward to deal with, would it be better with just a string instead? |
|
I kept having Ruby/Jekyll issues when upgrading my Mac, so I have moved off of Jekyll and will not be working on this project anymore, going forward. I am going to flag this as won’t fix, but leave it open in case someone else wants to pick up the project from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dupes #135 to main