Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ActiveInteractor::Context::Status #271

Closed
Tracked by #135
aaronmallen opened this issue Oct 21, 2020 · 0 comments · Fixed by #297
Closed
Tracked by #135

Deprecate ActiveInteractor::Context::Status #271

aaronmallen opened this issue Oct 21, 2020 · 0 comments · Fixed by #297
Labels
pending release The issue is resolved and waiting for release. wontfix This will not be worked on
Projects
ActiveInteractor 2.0 (rejected)
Milestone
v1.2.0

Comments

@aaronmallen
Copy link
Owner

aaronmallen commented Oct 21, 2020 •
edited

In a previous issue we have ensured interactors return a Result object, we now need to mark all the methods in ActiveInteractor::Context::Status as deprecated to be removed in version 2.0.0

Acceptance Criteria

  • When a method in ActiveInteractor::Context::Status is called a deprecation warning is logged.

Related Issues
@aaronmallen aaronmallen added this to To Do in ActiveInteractor 2.0 (rejected) via automation Oct 21, 2020
@aaronmallen aaronmallen mentioned this issue Oct 21, 2020
Closed
5 tasks
@aaronmallen aaronmallen moved this from To Do to Ready in ActiveInteractor 2.0 (rejected) Oct 21, 2020
@aaronmallen aaronmallen moved this from Ready to To Do in ActiveInteractor 2.0 (rejected) Oct 21, 2020
@aaronmallen aaronmallen added this to the v1.2.0 milestone Oct 21, 2020
@aaronmallen aaronmallen moved this from To Do to Ready in ActiveInteractor 2.0 (rejected) Oct 30, 2020
aaronmallen added a commit that referenced this issue Nov 4, 2020
@aaronmallen
#271 deprecate ActiveInteractor::Context::Status
f43d829
@aaronmallen aaronmallen mentioned this issue Nov 4, 2020
Merged
3 tasks
@aaronmallen aaronmallen moved this from Ready to In Review in ActiveInteractor 2.0 (rejected) Nov 4, 2020
aaronmallen added a commit that referenced this issue Nov 4, 2020
@aaronmallen
Merge pull request #297 from aaronmallen/chore/#271
43c105e 
#271 deprecate ActiveInteractor::Context::Status
@aaronmallen aaronmallen linked a pull request Nov 4, 2020 that will close this issue
#271 deprecate ActiveInteractor::Context::Status #297
Merged
3 tasks
@aaronmallen aaronmallen added the pending release The issue is resolved and waiting for release. label Nov 4, 2020
@aaronmallen aaronmallen moved this from In Review to Ready To Deploy in ActiveInteractor 2.0 (rejected) Nov 4, 2020
dark-panda pushed a commit to dark-panda/activeinteractor that referenced this issue Jan 8, 2021
@aaronmallen @dark-panda
aaronmallen#271 deprecate ActiveInteractor::Context::Status
9cff00a
dark-panda pushed a commit to dark-panda/activeinteractor that referenced this issue Jul 20, 2021
@aaronmallen @dark-panda
aaronmallen#271 deprecate ActiveInteractor::Context::Status
dfb491c
@aaronmallen aaronmallen added the wontfix This will not be worked on label Nov 11, 2021
ActiveInteractor 2.0 (rejected) automation moved this from Ready To Deploy to Done Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending release The issue is resolved and waiting for release. wontfix This will not be worked on
Projects
No open projects
ActiveInteractor 2.0 (rejected)
Done
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

#271 deprecate ActiveInteractor::Context::Status aaronmallen/activeinteractor
1 participant
@aaronmallen