Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure interactors return the result object #270

Closed
Tracked by #135
aaronmallen opened this issue Oct 21, 2020 · 0 comments · Fixed by #289 or #290
Closed
Tracked by #135

Ensure interactors return the result object #270

aaronmallen opened this issue Oct 21, 2020 · 0 comments · Fixed by #289 or #290
Labels
feature New feature or request pending release The issue is resolved and waiting for release. wontfix This will not be worked on
Projects
ActiveInteractor 2.0 (rejected)
Milestone
v1.2.0

Comments

@aaronmallen
Copy link
Owner

aaronmallen commented Oct 21, 2020 •
edited

In a previous issue we created a Result object that should behave in an identical manner to the current (v1.1.0) context object. We now need to ensure interactors return the Result object instead of the context object.

Acceptance Criteria

  • Interactors and Organizers still exhibit their current (v1.1.0) behavior
  • Interactors return a Result object instead of a context object.

Related Issues
@aaronmallen aaronmallen added the feature New feature or request label Oct 21, 2020
@aaronmallen aaronmallen added this to To Do in ActiveInteractor 2.0 (rejected) via automation Oct 21, 2020
This was referenced Oct 21, 2020
Closed
Closed
@aaronmallen aaronmallen moved this from To Do to Ready in ActiveInteractor 2.0 (rejected) Oct 21, 2020
@aaronmallen aaronmallen moved this from Ready to To Do in ActiveInteractor 2.0 (rejected) Oct 21, 2020
@aaronmallen aaronmallen added this to the v1.2.0 milestone Oct 21, 2020
@aaronmallen aaronmallen moved this from To Do to Ready in ActiveInteractor 2.0 (rejected) Oct 21, 2020
@aaronmallen aaronmallen moved this from Ready to In Progress in ActiveInteractor 2.0 (rejected) Oct 23, 2020
aaronmallen added a commit that referenced this issue Oct 27, 2020
@aaronmallen
#270 Result method_missing
6e76f39 
OpenStruct does not actually return true for respond_to when passing in a variable writer method so delegate_missing_to fails in this regard
@aaronmallen aaronmallen mentioned this issue Oct 27, 2020
Merged
3 tasks
aaronmallen added a commit that referenced this issue Oct 27, 2020
@aaronmallen
#270 Result method_missing
6245c73 
OpenStruct does not actually return true for respond_to when passing in a variable writer method so delegate_missing_to fails in this regard
aaronmallen added a commit that referenced this issue Oct 27, 2020
@aaronmallen
Merge pull request #289 from aaronmallen/feature/#270
6a92def 
#270 Result method_missing
@aaronmallen aaronmallen linked a pull request Oct 27, 2020 that will close this issue
#270 Result method_missing #289
Merged
3 tasks
aaronmallen added a commit that referenced this issue Oct 27, 2020
@aaronmallen
#270 ensure interactor returns a ActiveInteractor::Interactor::Result
c6d25f3
@aaronmallen aaronmallen mentioned this issue Oct 27, 2020
Merged
7 tasks
aaronmallen added a commit that referenced this issue Oct 28, 2020
@aaronmallen
#270 ensure interactor returns a ActiveInteractor::Interactor::Result
7f71ccc
aaronmallen added a commit that referenced this issue Oct 28, 2020
@aaronmallen
#270 ensure interactor returns a ActiveInteractor::Interactor::Result
712dadc
aaronmallen added a commit that referenced this issue Oct 30, 2020
@aaronmallen
Merge pull request #290 from aaronmallen/feature/#270
5a0e03a 
#270 ensure interactor returns a ActiveInteractor::Interactor::Result
@aaronmallen aaronmallen linked a pull request Oct 30, 2020 that will close this issue
#270 ensure interactor returns a ActiveInteractor::Interactor::Result #290
Merged
7 tasks
@aaronmallen aaronmallen added the pending release The issue is resolved and waiting for release. label Oct 30, 2020
@aaronmallen aaronmallen moved this from In Progress to Ready To Deploy in ActiveInteractor 2.0 (rejected) Oct 30, 2020
dark-panda pushed a commit to dark-panda/activeinteractor that referenced this issue Jan 8, 2021
@aaronmallen @dark-panda
aaronmallen#270 Result method_missing
9510e0b 
OpenStruct does not actually return true for respond_to when passing in a variable writer method so delegate_missing_to fails in this regard
dark-panda pushed a commit to dark-panda/activeinteractor that referenced this issue Jan 8, 2021
@aaronmallen @dark-panda
aaronmallen#270 ensure interactor returns a ActiveInteractor::Intera…
c75e936 
…ctor::Result
dark-panda pushed a commit to dark-panda/activeinteractor that referenced this issue Jul 20, 2021
@aaronmallen @dark-panda
aaronmallen#270 Result method_missing
499fb7a 
OpenStruct does not actually return true for respond_to when passing in a variable writer method so delegate_missing_to fails in this regard
dark-panda pushed a commit to dark-panda/activeinteractor that referenced this issue Jul 20, 2021
@aaronmallen @dark-panda
aaronmallen#270 ensure interactor returns a ActiveInteractor::Intera…
519ef8c 
…ctor::Result
@aaronmallen aaronmallen added the wontfix This will not be worked on label Nov 11, 2021
ActiveInteractor 2.0 (rejected) automation moved this from Ready To Deploy to Done Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request pending release The issue is resolved and waiting for release. wontfix This will not be worked on
Projects
No open projects
ActiveInteractor 2.0 (rejected)
Done
Milestone
v1.2.0
1 participant
@aaronmallen