Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#270 Result method_missing #289

Merged
merged 1 commit into from
Oct 27, 2020
Merged

#270 Result method_missing #289

merged 1 commit into from
Oct 27, 2020

Conversation

aaronmallen
Copy link
Owner

Description

Add method_missing to ActiveInteractor::Interactor::Result instead of using delegate_missing_to

OpenStruct does not actually return true for respond_to when passing in a variable writer method so delegate_missing_to fails in this regard.

Information

  • Contains Documentation
  • Contains Tests
  • Contains Breaking Changes

Related Issues

@aaronmallen aaronmallen added the bugfix Its a fix label Oct 27, 2020
@aaronmallen aaronmallen added this to the v1.2.0 milestone Oct 27, 2020
@aaronmallen aaronmallen added this to In Progress in ActiveInteractor 2.0 (rejected) via automation Oct 27, 2020
OpenStruct does not actually return true for respond_to when passing in a variable writer method so delegate_missing_to fails in this regard
@aaronmallen aaronmallen merged commit 6a92def into main Oct 27, 2020
ActiveInteractor 2.0 (rejected) automation moved this from In Review to Done Oct 27, 2020
@aaronmallen aaronmallen deleted the feature/#270 branch October 27, 2020 21:06
@aaronmallen aaronmallen linked an issue Oct 27, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Its a fix
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Ensure interactors return the result object
2 participants