Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with returned URIs #75

Closed
mcdodd opened this issue Oct 2, 2020 · 2 comments
Closed

Errors with returned URIs #75

mcdodd opened this issue Oct 2, 2020 · 2 comments

Comments

@mcdodd
Copy link

mcdodd commented Oct 2, 2020

Hi,

Thanks for the modules, really working well.

On Get-Cyberduck, the returned URI is missing a "/" in the URI
i.e. it returns **https:/**update.cyberduck.io/......

That seems to be true on all channels for this product.

Thanks
Matthew

@mcdodd mcdodd changed the title Get-Cyberduck returns invalid URI Errors with returned URIs Oct 2, 2020
@mcdodd
Copy link
Author

mcdodd commented Oct 2, 2020

Additionally, Get-Filezilla returns a URL which doesn't succeed - wget reports receiving a 301 redirect to https://filezilla-project.org/, and the same experience when pasting into a browser.

Currently Get-Filezilla returns the following for URI: https://dl2.cdn.filezilla-project.org/FileZilla_3.50.0_win64-setup.exe

@aaronparker
Copy link
Owner

aaronparker commented Oct 3, 2020

The Cyberduck update feed is returning an incorrectly formatted URL:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<rss xmlns:sparkle="http://www.andymatuschak.org/xml-namespaces/sparkle" version="2.0">
    <channel>
        <title>Cyberduck Changelog</title>
        <link>https://cyberduck.io/changelog</link>
        <description>Cyberduck Changelog.</description>
        <language>en-us</language>
        <copyright>Copyright (c) 2001-2020 David Kocher. Copyright (c) 2011-2020 Yves Langisch</copyright>
        <item>
            <title>Cyberduck 7.6.2 (Revision 33520)</title>
            <pubDate>30/09/2020 10:29 AM</pubDate>
            <enclosure sparkle:dsaSignature="MC0CFQCPUyJ40sA7OPzlj9RepHNJ2Rr4QAIUKAGnL9D41VbDpJc/b4NjAjUiO9Y=" sparkle:installerArguments="/passive Autostart=1" sparkle:shortVersionString="7.6.2" sparkle:version="33520" type="application/octet-stream" url="https://update.cyberduck.io//Cyberduck-Installer-7.6.2.33520.exe"/>
            <sparkle:releaseNotesLink>https://version.cyberduck.io/windows//changelog.html</sparkle:releaseNotesLink>
        </item>
    </channel>
</rss>

I'll remove the filtering on additional / characters for the time being. Invoke-WebRequest still handles multiple // characters OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants