Latest Flash not returning server updates

[Fonta]

Hi Aaron,

Something seems to be off with Get-LatestAdobeFlashUpdate. No matter which arguments I provide, it doesn't seem to return the latest flash update for Windows Server 2016/2019.

Here it doesn't return the latest flash update for Windows Server 2019.

It also seems to return duplicate entries for build 1607 and also here the update for Server 2016 is missing.

[aaronparker]

If you run this with -Verbose, you'll see that it builds a search query for the Catalog: https://www.catalog.update.microsoft.com/Search.aspx?q=KB4503308+1809. From the feed this is the latest update. The catalog doesn't return any updates with Windows Server 2019 in the title.

Even a search for "adobe flash 1809" doesn't return Windows Server 2019 updates either. Searching for "2016" or "2019" does return updates.

Windows 10 x64 updates are applicable to Windows Server 2019 of course. I don't really want to add code just for 2016/2019 when the Windows 10 x64 updates apply.

[Fonta]

It does return results with "Windows Server 2019" in the name:

Also searching for the latest KB returns the windows server 2016/2019 etc wanted results:

Before your changes, it did return these results. So currently the function is returning incomplete/incorrect results.
Using it like -OS Windows10 -Version 1809 does not return the wanted results anymore.

[Fonta]

Thanks for merging my PR. I was just thinking that it might be an idea to make the default fallback on PSCore to webclient as downloading is faster than using WebRequest as you can see in the screenshot underneath:

Also in Powershell 5, the difference is a lot bigger:

These test result are produced by the following small script: https://pastebin.com/0iksKb0w

[aaronparker]

I might look at using WebClient the default for all requests in the release after next. Querying the catalog could be faster and WebClient might help.

[Fonta]

That would be best I guess. Would also help with implementing proxy support.